Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename data directory to seeds #4589

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Rename data directory to seeds #4589

merged 2 commits into from
Jan 19, 2022

Conversation

joellabes
Copy link
Contributor

@joellabes joellabes commented Jan 19, 2022

resolves #4588

Description

The sample project data directory had the wrong name. Now it doesn't!

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@cla-bot cla-bot bot added the cla:yes label Jan 19, 2022
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Looks good!

@emmyoop emmyoop merged commit 348764d into main Jan 19, 2022
@emmyoop emmyoop deleted the rename-data-directory-to-seeds branch January 19, 2022 16:04
@jtcohen6
Copy link
Contributor

Nice catch + quick work, team! Let's make sure this one gets backported to 1.0.latest, for inclusion in 1.0.2

emmyoop pushed a commit that referenced this pull request Jan 19, 2022
* Rename data directory to seeds

* Update CHANGELOG.md
# Conflicts:
#	CHANGELOG.md
emmyoop added a commit that referenced this pull request Jan 20, 2022
* Rename data directory to seeds

* Update CHANGELOG.md
# Conflicts:
#	CHANGELOG.md

Co-authored-by: Joel Labes <[email protected]>
@leahwicz leahwicz added the backport 1.0.latest Tag for PR to be backported to the 1.0.latest branch label Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.0.latest Tag for PR to be backported to the 1.0.latest branch cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-66] [Bug] dbt starter project's seed folder is still called data
4 participants