Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid saving secrets in SecretContext #4665

Merged
merged 4 commits into from
Feb 3, 2022
Merged

Avoid saving secrets in SecretContext #4665

merged 4 commits into from
Feb 3, 2022

Conversation

nathaniel-may
Copy link
Contributor

resolves #4650

Description

Prevents saving secret environment variables so that partial parsing doesn't get triggered on secret changes.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@cla-bot cla-bot bot added the cla:yes label Feb 2, 2022
@leahwicz
Copy link
Contributor

leahwicz commented Feb 3, 2022

This draft LGTM overall

@nathaniel-may nathaniel-may marked this pull request as ready for review February 3, 2022 17:39
@nathaniel-may nathaniel-may requested review from a team as code owners February 3, 2022 17:39
@nathaniel-may nathaniel-may requested review from stu-k, leahwicz, gshank and jtcohen6 and removed request for a team February 3, 2022 17:39
Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-114] Avoid saving secrets in SecretContext
3 participants