Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mashumaro[msgpack] from 3.1.1 to 3.2 in /core #6375

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 5, 2022

Bumps mashumaro[msgpack] from 3.1.1 to 3.2.

Release notes

Sourced from mashumaro[msgpack]'s releases.

v3.2

Changes

  • Added support for PEP 655
  • Added skipping None value fields on serialization to TOML format. See Fatal1ty/mashumaro#85.
  • Added new omit_none config option
  • Added new omit_none dialect option
  • Removed allowance to pass None values to fields that can't be None according to their type
  • Speeded up the generated code
  • Dropped Python 3.6 support
Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [mashumaro[msgpack]](https:/Fatal1ty/mashumaro) from 3.1.1 to 3.2.
- [Release notes](https:/Fatal1ty/mashumaro/releases)
- [Commits](Fatal1ty/mashumaro@v3.1.1...v3.2)

---
updated-dependencies:
- dependency-name: mashumaro[msgpack]
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner December 5, 2022 00:20
@dependabot dependabot bot added dependencies Changes to the version of dbt dependencies python Pull requests that update Python code labels Dec 5, 2022
@cla-bot cla-bot bot added the cla:yes label Dec 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@joshuataylor
Copy link
Contributor

joshuataylor commented Dec 5, 2022

Ah I just was wanting this as it's got a couple of nifty features in a project that relies on dbt-core.

Considering #6108 was just merged last week to little fuss, dbt-core could either use the exact version or set "mashumaro[msgpack]>=3.1.1,<=3.2", in core/setup.py.

Changes

Things dbt-core (probably) cares about:

Added support for PEP 655

This is super handy, will come in use

Removed allowance to pass None values to fields that can't be None according to their type

Speeded up the generated code

:sonic:

Dropped Python 3.6 support

dbt-core doesn't support 3.6, which Mashumaro 3.2 drops.

@jtcohen6
Copy link
Contributor

jtcohen6 commented Dec 5, 2022

@joshuataylor We've kept the mashumaro dependency tightly pinned because there have been (unintented) breaking changes in past minor + patch releases — which can be thorny to debug, since the interaction points are at such a low level.

That said, I don't see a reason why we couldn't upgrade the pin from mashumaro==3.1.1 to 3.2. It looks like all tests are passing on this PR.

@jtcohen6 jtcohen6 added support_rotation A good task to pick up during support rotation Team:Language labels Dec 6, 2022
@gshank gshank merged commit 0721f2c into main Dec 7, 2022
@gshank gshank deleted the dependabot/pip/core/mashumaro-msgpack--3.2 branch December 7, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes dependencies Changes to the version of dbt dependencies python Pull requests that update Python code support_rotation A good task to pick up during support rotation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants