CT 1894 log partial parsing var changes and sort cli vars before hashing #6713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for adding this logging (and the argument normalization!), it'll be super helpful! |
dbeatty10
reviewed
Jan 25, 2023
Co-authored-by: Doug Beatty <[email protected]>
dbeatty10
reviewed
Jan 25, 2023
peterallenwebb
approved these changes
Jan 25, 2023
|
@gshank Is this something you'd feel comfortable backporting for inclusion in a v1.4.x patch release? The changes look quite minor:
(cc @bossnunta) |
|
Yes, should be pretty straightforward to backport. Will do that. |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 26, 2023
…ing (#6713) * Log information about vars_hash, normalize cli_vars before hashing * Changie * Add to test_events.py * Update core/dbt/events/types.py Co-authored-by: Doug Beatty <[email protected]> (cherry picked from commit a34521e)
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6710
Description
If the order of vars passed on the command line changes, then partial parsing will be aborted. Sort the vars before hashing in order to avoid unnecessary reparsing.
Checklist
changie newto create a changelog entry