[CT-920][CT-1900] Create Click CLI runner and use it to fix dbt docs … #6723
Conversation
| click.echo(f"Serving docs at {port}") | ||
| click.echo(f"To access from your browser, navigate to: http://localhost:{port}") | ||
| click.echo("\n\n") | ||
| click.echo("Press Ctrl+C to exit.") |
There was a problem hiding this comment.
This change makes sense to me. docs serve is CLI-only functionality; it might make more sense to just click.echo, rather than firing a real event.
If we did want these to keep being "real" events / log messages, we could use the Formatting ("FYI") message type that @peterallenwebb added in #6691. I leave it up to your discretion.
In any case, I think we could also just remove the one-off event types that are no longer being used anywhere else in the codebase: ServingDocsPort, ServingDocsAccessInfo, ServingDocsExitInfo
There was a problem hiding this comment.
I'll keep these click.echo for now, have removed the one-off event types.
There was a problem hiding this comment.
We should add another command to tox.ini to run tests for tests/cli locally and in CI via tox, or consider moving cli/test_cli_run.py under tests/functional (my preference, since it's using the same underlying framework)
|
@MichelleArk You beat me to it ;) |
resolves #5544 #6722
Description
Checklist
changie newto create a changelog entry