Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --quiet CLI Parameter Regression #6858

Closed
wants to merge 2 commits into from

Conversation

peterallenwebb
Copy link
Contributor

@peterallenwebb peterallenwebb commented Feb 3, 2023

resolves #6749

Description

This change addresses a regression which caused dbt to write non-error messages to the console, even when the -q/--quiet flag was used. This happened when the messages were logged before the final log configuration was available. This fix aims to set the log level to error-only as soon as the cli parameters are parsed and -q/--quiet is detected.

Checklist

@cla-bot cla-bot bot added the cla:yes label Feb 3, 2023
@peterallenwebb peterallenwebb changed the base branch from main to 1.4.latest February 3, 2023 21:41
@peterallenwebb peterallenwebb marked this pull request as ready for review February 7, 2023 15:19
@peterallenwebb peterallenwebb requested a review from a team February 7, 2023 15:19
@peterallenwebb peterallenwebb requested review from a team as code owners February 7, 2023 15:19
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me.

@peterallenwebb peterallenwebb changed the base branch from 1.4.latest to main February 7, 2023 19:22
@peterallenwebb peterallenwebb requested review from a team and leahwicz as code owners February 7, 2023 19:22
@peterallenwebb peterallenwebb changed the base branch from main to 1.4.latest February 7, 2023 19:22
@peterallenwebb
Copy link
Contributor Author

Will re-open with the same changes against main.

@peterallenwebb peterallenwebb deleted the paw/ct-1917-quiet-regression branch May 16, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2022] Non-error log is not silenced by -q flag, Click Version
2 participants