Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty catalog dbt docs generate #7202

Merged
merged 12 commits into from
Apr 20, 2023

Conversation

AndyBys
Copy link
Contributor

@AndyBys AndyBys commented Mar 21, 2023

resolves #6980

Description

Checklist

@cla-bot
Copy link

cla-bot bot commented Mar 21, 2023

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @AndyBys

@cla-bot
Copy link

cla-bot bot commented Mar 21, 2023

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @AndyBys

@cla-bot
Copy link

cla-bot bot commented Mar 21, 2023

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @AndyBys

@AndyBys AndyBys marked this pull request as ready for review March 21, 2023 21:36
@AndyBys AndyBys requested a review from a team March 21, 2023 21:36
@AndyBys AndyBys requested a review from a team as a code owner March 21, 2023 21:36
@AndyBys AndyBys requested review from iknox-fa and stu-k March 21, 2023 21:36
@cla-bot
Copy link

cla-bot bot commented Mar 21, 2023

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @AndyBys

@jaypeedevlin
Copy link
Contributor

Since I created the original issue, putting in my two cents that I don't love the skip_catalogue_generation name since it does generate a catalog.json (albeit empty)

@AndyBys
Copy link
Contributor Author

AndyBys commented Mar 23, 2023

Hey, thanks for feedback. Sounds good to me. Going to replace it for empty_catalog instead to align with logic. However I'm happy to hear any feedback on it so it match all needs and demand on this flag.

PS Turn to Closed due to misclick.

@AndyBys AndyBys closed this Mar 23, 2023
@AndyBys AndyBys reopened this Mar 23, 2023
@AndyBys AndyBys changed the title Skip catalog generation dbt docs generate Empty catalog dbt docs generate Mar 27, 2023
@cla-bot cla-bot bot added the cla:yes label Mar 27, 2023
@jtcohen6 jtcohen6 added Team:Execution ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering labels Mar 29, 2023
Copy link
Contributor

@iknox-fa iknox-fa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have one small suggestion for readability but it looks good logically. Thanks for your contribution!

@iknox-fa iknox-fa removed the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Apr 20, 2023
@iknox-fa iknox-fa merged commit aac034d into dbt-labs:main Apr 20, 2023
@aranke aranke mentioned this pull request May 9, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2124] [Feature] --no-connection flag for dbt docs generate
4 participants