Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbt.include import issue for ci #7383

Merged
merged 11 commits into from
Apr 18, 2023
Merged

dbt.include import issue for ci #7383

merged 11 commits into from
Apr 18, 2023

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Apr 18, 2023 •
edited
Loading

Description

The code quality check is not properly installing dbt-core. This fixes that.

Checklist

@mikealfare mikealfare self-assigned this Apr 18, 2023
@cla-bot cla-bot bot added the cla:yes label Apr 18, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Apr 18, 2023
@mikealfare mikealfare marked this pull request as ready for review April 18, 2023 01:43
@mikealfare mikealfare requested a review from a team as a code owner April 18, 2023 02:06
@mikealfare mikealfare mentioned this pull request Apr 18, 2023
Closed
6 tasks
@mikealfare mikealfare added Skip Changelog Skips GHA to check for changelog file and removed Skip Changelog Skips GHA to check for changelog file labels Apr 18, 2023
@mikealfare mikealfare requested review from gshank and aranke and removed request for leahwicz and iknox-fa April 18, 2023 03:08
aranke
aranke approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikealfare mikealfare merged commit 121fa57 into main Apr 18, 2023
@mikealfare mikealfare deleted the mikealfare/dbt-include-import-issue branch April 18, 2023 05:08
@jtcohen6 jtcohen6 mentioned this pull request Apr 18, 2023
Merged
6 tasks
@aranke aranke mentioned this pull request May 9, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathaniel-may nathaniel-may nathaniel-may approved these changes

@aranke aranke aranke approved these changes

@gshank gshank Awaiting requested review from gshank

Assignees

@mikealfare mikealfare

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikealfare @nathaniel-may @aranke