Fix inverted --print/--no-print flag
#7524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
dbeatty10
added
the
ready_for_review
|
Closing and re-opening to try to re-trigger this CI check:
|
|
I do not know why the snyk check seems to be hanging on all PRs :( If we can't figure it out early this week, I can disable it as a required check. |
github-actions bot
pushed a commit
that referenced
this pull request
May 8, 2023
(cherry picked from commit 19d6dab)
jtcohen6
pushed a commit
that referenced
this pull request
May 8, 2023
(cherry picked from commit 19d6dab) Co-authored-by: Doug Beatty <[email protected]>
|
@dbeatty10 Thank you for quickly fixing it. Can you tell me when dbt-core 1.5.1 gets available? I would like to know the fixed version right now. |
|
We'll be putting out a release candidate of 1.5.1 this week, including all fixes that have been merged far |
|
@jtcohen6 Thank you for sharing the information. I look forward to it! |
This was referenced Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7517
Description
This flag must not have the relevant tests, or this wouldn't have been able to slip through during this re-factor. And I didn't add any relevant tests.
Maybe the reviewer would be so kind as to add them? 🙏 Will offer co-authorship as a reward 😎
Checklist
changie newto create a changelog entry