Snowflake default unquoted (#824) #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
force-pushed
the
snowflake-default-unquoted
branch
from
0e58b2b
to
a898516
Compare
added 5 commits
August 21, 2018 15:43
beckjake
force-pushed
the
snowflake-default-unquoted
branch
from
26d0925
to
6435c0f
Compare
added 3 commits
August 21, 2018 16:02
…ke does not care about varchar sizes below 16777216
beckjake
force-pushed
the
snowflake-default-unquoted
branch
from
2ee3dd7
to
90ea0e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #824. The actual code changes are fairly simple, but this required extensive test changes to the base test class. I'm still not totally confident in them, the integration tests make a lot of quoting-related assumptions, but the tests do seem to pass and the test changes I made to the regular test files seem reasonable. I think this adventure exposed that there are probably some more tests we should add (like a
TestSimpleCopyUppercasedSchemathat forces uppercase schemas and tests non-snowflake dbs), but I think that's a separate PR/issue.