Bigquery clustering columns (#918) #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks ok to me, @drewbanin can you take a look? |
cmcarthur
approved these changes
Sep 11, 2018
drewbanin
reviewed
Sep 11, 2018
| {% endif %} | ||
|
|
||
| {% set cluster_by_clause %} | ||
| cluster by {{ raw_cluster_by }} |
There was a problem hiding this comment.
i think this is supposed to be a CSV of column names. That means that folks would do something like
{{
config(
materialized='table',
cluster_by='field_1, field_2'
)
}}
I think that's reasonable, but we accept an actual list of values in other similar configs: https:/fishtown-analytics/dbt/blob/development/dbt/include/global_project/macros/adapters/redshift.sql#L21
all things being equal, I think it would be good to keep this interface with other configs like this!
drewbanin
approved these changes
Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add clustering support to bigquery adapter, include it in the stats output, add tests.
Fixes #918.