Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a title tag to elements in the tree #203

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

miike
Copy link
Contributor

@miike miike commented Jul 11, 2021

resolves #202

Description

Adds a title attribute to elements in the node list which allows the user to hover / screen read each item in the list.

Checklist

  • I have signed the CLA
  • I have generated docs locally, and this change appears to resolve the stated issue
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Jul 11, 2021
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @miike! So sorry for the delay getting back to you on this one. I'm going to merge this in now, for inclusion in dbt Core v1.0.0-rc1.

@jtcohen6 jtcohen6 merged commit 5f791fe into dbt-labs:master Nov 7, 2021
@miike
Copy link
Contributor Author

miike commented Nov 8, 2021

No worries - thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add title attribute to nodes in the tree list
2 participants