Adds support for dbt Deps #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
racheldaniel
changed the title
kwigley
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
/depsendpoint that expects a dict of packages with package (name) and version keys, uses the core functionpackage_versionto make a call to the hub API for package details, and returns all necessary details for package installation to the client.Right now I'm differentiating hub packages by expecting the
packageandversionkeys (as other package types use different keys). I have no idea whether or not this is sound. As it stands, if the package requested is not available on the hub site, the server will return the error to the client (status will be 200, butokwill beFalseand the data will contain the error). If this dbt-server PR is approved, I'll update this handling to match RuntimeException handling (though perhaps not with a blanket catch) and will update handling client-side accordingly.Corresponding PR in dbt-client: https:/dbt-labs/dbt-client/pull/10
Small change made to dbt-core: dbt-labs/dbt-core#4218