Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ct 716 add materialization -- file reformat #192

Merged
merged 34 commits into from
Jul 13, 2022

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Jul 12, 2022

Description

Minor file reformat to pull things out of adapter.sql and make macros more inline with core naming structure location.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-snowflake next" section.

McKnight-42 and others added 29 commits June 27, 2022 11:10
…/dbt-snowflake into ct-716-add-materialization
@cla-bot cla-bot bot added the cla:yes label Jul 12, 2022
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge, once you take care of moving the changelog entry

CHANGELOG.md Outdated
Comment on lines 10 to 11
### Under the Hood
- Reformat overridden macro location of grants work to a apply_grants.sql file in snowflake ([#193](https:/dbt-labs/dbt-snowflake/issues/193), [#192](https:/dbt-labs/dbt-snowflake/pull/192))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you pop this up to a new section, 1.3.0b1?

(this will be much easier once we have changie running in this repo!)

@McKnight-42 McKnight-42 merged commit d165385 into main Jul 13, 2022
@McKnight-42 McKnight-42 deleted the ct-716-add-materialization branch July 13, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants