Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore adapter mypy check #258

Merged
merged 2 commits into from
Sep 13, 2022
Merged

ignore adapter mypy check #258

merged 2 commits into from
Sep 13, 2022

Conversation

colin-rogers-dbt
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt commented Sep 13, 2022 •
edited
Loading

resolves #185

Description

Thanks to this change we are now properly inheriting typing from dbt-core resulting in mypy discovering new conflicts. Ignoring these for now and creating a new issue to investigate further at later date.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have run changie new to create a changelog entry

@cla-bot cla-bot bot added the cla:yes label Sep 13, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

dbeatty10
dbeatty10 approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @colin-rogers-dbt !

@colin-rogers-dbt colin-rogers-dbt merged commit 902b9f3 into main Sep 13, 2022
@colin-rogers-dbt colin-rogers-dbt deleted the ignoreNewMyPyIssues branch September 13, 2022 22:30
@leahwicz
Copy link
Contributor

@colin-rogers-dbt I'm closing this issue out since I think this resolves it #259

@dbeatty10
Copy link
Contributor

@colin-rogers-dbt this description says it resolves "185":
image

Was that a mistake? Is it supposed to be "259" instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbeatty10 dbeatty10 dbeatty10 approved these changes

@VersusFacit VersusFacit Awaiting requested review from VersusFacit

@nathaniel-may nathaniel-may Awaiting requested review from nathaniel-may

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colin-rogers-dbt @leahwicz @dbeatty10