Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jpmmcneill/snowflake type boolean #268

Merged
merged 3 commits into from
Sep 22, 2022
Merged

Jpmmcneill/snowflake type boolean #268

merged 3 commits into from
Sep 22, 2022

Conversation

jpmmcneill
Copy link
Contributor

resolves #267

Description

snowflake component of dbt-labs/dbt-core#5875

Checklist

@cla-bot cla-bot bot added the cla:yes label Sep 19, 2022
@jpmmcneill jpmmcneill changed the title Jommcneill/snowflake type boolean Jpmmcneill/snowflake type boolean Sep 19, 2022
@dbeatty10
Copy link
Contributor

@jpmmcneill this one looks like it is missing the changie entry.

@dbeatty10 dbeatty10 added Skip Changelog Skips GHA to check for changelog file ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering and removed Skip Changelog Skips GHA to check for changelog file labels Sep 20, 2022
@dbeatty10
Copy link
Contributor

@jpmmcneill Now that dbt-labs/dbt-core#5875 has been merged, just three things and then this should be ready!

  1. Click the "update branch" button (or merge the latest changes from main some other way)
  2. Restore the original version of dbt-requirements.txt
  3. Run changie new to add a changelog entry

If all looks good after CI runs, then we'll merge.

@jpmmcneill
Copy link
Contributor Author

@dbeatty10 just realised there was a typo in this branch name which is why my changie didn't go through 🤦. Have added and cleaned up commit history now :)

@dbeatty10 dbeatty10 merged commit 910f9a5 into dbt-labs:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1211] [Feature] Cross-database macro for type_boolean()
2 participants