consolidate timestamp macros

[colin-rogers-dbt]

resolves #276

Description

Checklist

• I have read the contributing guide and understand what's expected of me
• I have signed the CLA
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
• I have run changie new to create a changelog entry

[github-actions]

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

removed, will look into dev reqs later

[dbeatty10]

This looks good 👍

Left one comment for you to take a peek at related to casing and another related to pytest class conventions.

✅ Manually confirmed the same results that you got in your automated tests:

Output

snowflake dbt_utils.current_timestamp(): 
    current_timestamp::TIMESTAMP

snowflake dbt.current_timestamp_backcompat(): 
  current_timestamp::TIMESTAMP

snowflake dbt_utils.current_timestamp_in_utc(): 
    convert_timezone('UTC', 
    current_timestamp::TIMESTAMP
)::TIMESTAMP

snowflake dbt.current_timestamp_in_utc_backcompat(): 
  convert_timezone('UTC', 
  current_timestamp::TIMESTAMP
)::TIMESTAMP

Merge notes

After dbt-labs/dbt-core#5838 is merged, then you can commit an update to dev-requirements.txt in this PR prior to merging it.

[dbeatty10]

The pattern I've seen in our code is like this:

from dbt.tests.adapter.utils.test_timestamps import BaseCurrentTimestamps

class TestCurrentTimestampSnowflake(BaseCurrentTimestamps):

We can keep the discussion about this over here and here though. Just pointing this out for sake of completeness.

[colin-rogers-dbt]

updated

[dbeatty10]

Per @gshank's comment here, let's make this consistent with the rest of the code base.

Suggested change

	from dbt.tests.adapter.utils import test_timestamps
	_MODEL_CURRENT_TIMESTAMP = """
	SELECT {{current_timestamp()}} as current_timestamp,
	{{current_timestamp_in_utc_backcompat()}} as current_timestamp_in_utc_backcompat,
	{{current_timestamp_backcompat()}} as current_timestamp_backcompat
	"""
	class TestCurrentTimestampSnowflake(test_timestamps.BaseCurrentTimestamps):
	from dbt.tests.adapter.utils.test_timestamps import BaseCurrentTimestamps
	_MODEL_CURRENT_TIMESTAMP = """
	SELECT {{current_timestamp()}} as current_timestamp,
	{{current_timestamp_in_utc_backcompat()}} as current_timestamp_in_utc_backcompat,
	{{current_timestamp_backcompat()}} as current_timestamp_backcompat
	"""
	class TestCurrentTimestampSnowflake(BaseCurrentTimestamps):

[dbeatty10]

👍