CT-2112: bump snowflake connector python #476

mikealfare · 2023-02-17T17:09:47Z

Description

Patches snowflake-connector-python vulnerability https://www.cve.org/CVERecord?id=CVE-2022-42965.

Update snowflake-connector-python to 3.0
Remove explicit dependencies on cryptography and requests; these are covered in dbt-core and snowflake-connector-python -> reduces potential for version conflicts
Add several docker files for development purposes to troubleshoot failed tests
Fixed test case that was failing due to failed teardown

Note: This will need to be backported into 1.4.latest, 1.3.latest, 1.2.latest, and 1.1.latest

We suspect this will also resolve issue #393 as that was tied back to an older version of snowflake-connector-python. The priority is to resolve the vulnerability, but testing will be done for this issue as well. If there is additional work to be done for #393, a new PR will be opened to cover the gap.

Checklist

I have read the contributing guide and understand what's expected of me
I have signed the CLA
I have run this code in development and it appears to resolve the stated issue
This PR includes tests, or tests are not required/relevant for this PR
I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
I have run changie new to create a changelog entry

…ector-python`

.changes/unreleased/Dependencies-20230216-093128.yaml

setup.py

dbeatty10

We need to finalize the upper and lower bounds before merging.

Adding this blocking comment so we can be extra certain the merged PR has the upper and lower bounds that align with the final decision.

…-python' into dbeatty/bump-snowflake-connector-python

setup.py

…le instructions for easy deployment

…ed warning readme file

…-python' into dbeatty/bump-snowflake-connector-python

…ents updates helped this

…-python' into dbeatty/bump-snowflake-connector-python

… as expected, but on the vulnerable version

…-python' into dbeatty/bump-snowflake-connector-python

dbeatty10

Version range for snowflake-connector-python looks good 👍

Nice that you were also able to:

Remove explicit dependencies for cryptography and requests
Greatly simplify test_simple_seed.py

* Raise the upper bound to be the next major version of `snowflake-connector-python` * Changelog entry * updated changelog to show specific version * added changelog for updated build dependencies --------- Co-authored-by: Doug Beatty <[email protected]> Co-authored-by: Doug Beatty <[email protected]>

* Raise the upper bound to be the next major version of `snowflake-connector-python` * Changelog entry * Update .changes/unreleased/Dependencies-20230216-093128.yaml * updated changelog to show specific version * added changelog for updated build dependencies --------- Co-authored-by: Doug Beatty <[email protected]> Co-authored-by: Doug Beatty <[email protected]>

* Raise the upper bound to be the next major version of `snowflake-connector-python` * Changelog entry * Update .changes/unreleased/Dependencies-20230216-093128.yaml * created ubuntu-py38 image for local integration testing, added makefile instructions for easy deployment * added debian image * added docker dev-environment image * added additional python versions in ubuntu and debian containers, added warning readme file * resolved five of seven failing tests * resolved TestSimpleBigSeedBatched.test_big_batched_seed() test failure * updated changelog to show specific version * added changelog for updated build dependencies --------- Co-authored-by: Doug Beatty <[email protected]> Co-authored-by: Doug Beatty <[email protected]>

* Raise the upper bound to be the next major version of `snowflake-connector-python` * Changelog entry --------- Co-authored-by: Doug Beatty <[email protected]> Co-authored-by: Doug Beatty <[email protected]>

* updated changelog entry * updated changelog entry file name

dbeatty10 and others added 3 commits February 16, 2023 09:29

Raise the upper bound to be the next major version of `snowflake-conn…

823f1cb

…ector-python`

Changelog entry

b5355d9

Merge branch 'main' into dbeatty/bump-snowflake-connector-python

88b4ae1

cla-bot bot added the cla:yes label Feb 17, 2023

mikealfare and others added 2 commits February 17, 2023 12:11

bumping snowflake-connector-python to latest 2.x

d5fb8ac

Merge branch 'main' into dbeatty/bump-snowflake-connector-python

3545bec

mikealfare marked this pull request as draft February 17, 2023 17:38

dbeatty10 reviewed Feb 17, 2023

View reviewed changes

.changes/unreleased/Dependencies-20230216-093128.yaml Outdated Show resolved Hide resolved

setup.py Outdated Show resolved Hide resolved

Update .changes/unreleased/Dependencies-20230216-093128.yaml

d49da93

dbeatty10 requested changes Feb 17, 2023

View reviewed changes

mikealfare added 3 commits February 17, 2023 12:52

bumping snowflake-connector-python to latest working version of 2.x

1b5103f

Merge remote-tracking branch 'origin/dbeatty/bump-snowflake-connector…

89a2121

…-python' into dbeatty/bump-snowflake-connector-python

bumping snowflake-connector-python to latest working version of 2.x

72b1a91

dbeatty10 reviewed Feb 17, 2023

View reviewed changes

setup.py Outdated Show resolved Hide resolved

mikealfare and others added 15 commits February 22, 2023 15:09

created ubuntu-py38 image for local integration testing, added makefi…

adba22c

…le instructions for easy deployment

added debian image

dce899f

added docker dev-environment image

da070d0

added additional python versions in ubuntu and debian containers, add…

b785921

…ed warning readme file

added additional python versions in ubuntu and debian containers, add…

e569941

…ed warning readme file

added additional python versions in ubuntu and debian containers, add…

0753169

…ed warning readme file

updated build requirements, added py311

d1812c1

Merge branch 'main' into dbeatty/bump-snowflake-connector-python

8a886b6

Merge remote-tracking branch 'origin/dbeatty/bump-snowflake-connector…

2aa5484

…-python' into dbeatty/bump-snowflake-connector-python

pinned snowflake-connector-python to 2.9 to check if other requirem…

c6a29e1

…ents updates helped this

Merge branch 'main' into dbeatty/bump-snowflake-connector-python

0fedeef

Merge remote-tracking branch 'origin/dbeatty/bump-snowflake-connector…

99f9e2c

…-python' into dbeatty/bump-snowflake-connector-python

Merge branch 'main' into dbeatty/bump-snowflake-connector-python

664127f

pinned snowflake-connector-python to 2.8.1 to verify that tests run…

3503bd8

… as expected, but on the vulnerable version

Merge remote-tracking branch 'origin/dbeatty/bump-snowflake-connector…

355594c

…-python' into dbeatty/bump-snowflake-connector-python

mikealfare self-assigned this Mar 4, 2023

mikealfare added backport 1.2.latest labels Mar 4, 2023

This was linked to issues Mar 4, 2023

[CT-1813] [CT-1378] [Bug] Python models not picking up custom schema #393

Closed

[CT-1707] [Bug] Testing locally is slow, and hangs #371

Closed

This was referenced Mar 6, 2023

[CT-1813] [CT-1378] [Bug] Python models not picking up custom schema #393

Closed

[CT-1529] [Feature] Support Python 3.11 #331

Closed

nssalian approved these changes Mar 7, 2023

View reviewed changes

dbeatty10 approved these changes Mar 8, 2023

View reviewed changes

mikealfare merged commit 967a8e9 into main Mar 8, 2023

mikealfare deleted the dbeatty/bump-snowflake-connector-python branch March 8, 2023 15:11

mikealfare mentioned this pull request Mar 9, 2023

Fix change log entry for #476 #511

Merged

6 tasks

mikealfare added a commit that referenced this pull request Mar 9, 2023

Fix change log entry for #476 (#511)

8a33683

* updated changelog entry * updated changelog entry file name

mikealfare added a commit that referenced this pull request Mar 9, 2023

Fix change log entry for #476 (#511)

a7c9d83

* updated changelog entry * updated changelog entry file name

mikealfare added a commit that referenced this pull request Mar 9, 2023

Fix change log entry for #476 (#511)

bae5570

* updated changelog entry * updated changelog entry file name

mikealfare added a commit that referenced this pull request Mar 9, 2023

Fix change log entry for #476 (#511)

89d9770

* updated changelog entry * updated changelog entry file name

mikealfare added a commit that referenced this pull request Mar 9, 2023

Fix change log entry for #476 (#511)

98c5c97

* updated changelog entry * updated changelog entry file name

mikealfare added a commit that referenced this pull request Mar 9, 2023

Fix change log entry for #476 (#511) (#515)

c8adb36

* updated changelog entry * updated changelog entry file name

mikealfare added a commit that referenced this pull request Mar 9, 2023

Fix change log entry for #476 (#511) (#514)

1334593

* updated changelog entry * updated changelog entry file name

mikealfare added a commit that referenced this pull request Mar 9, 2023

Fix change log entry for #476 (#511) (#513)

638a106

* updated changelog entry * updated changelog entry file name

mikealfare added a commit that referenced this pull request Mar 9, 2023

Fix change log entry for #476 (#511) (#512)

72ee1f4

* updated changelog entry * updated changelog entry file name

dataders mentioned this pull request Jul 11, 2023

[ADAP-692] [Bug] snowflake-connector-python dependency version too strict #687

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CT-2112: bump snowflake connector python #476

CT-2112: bump snowflake connector python #476

mikealfare commented Feb 17, 2023 •

edited

Loading

dbeatty10 left a comment

dbeatty10 left a comment

CT-2112: bump snowflake connector python #476

CT-2112: bump snowflake connector python #476

Conversation

mikealfare commented Feb 17, 2023 • edited Loading

Description

Checklist

dbeatty10 left a comment

Choose a reason for hiding this comment

dbeatty10 left a comment

Choose a reason for hiding this comment

mikealfare commented Feb 17, 2023 •

edited

Loading