Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dispatch pattern for get_columns_in_relation_raw macro #365

Merged
merged 1 commit into from
May 31, 2022
Merged

Use dispatch pattern for get_columns_in_relation_raw macro #365

merged 1 commit into from
May 31, 2022

Conversation

ueshin
Copy link
Contributor

@ueshin ueshin commented May 23, 2022

Description

Use dispatch pattern for get_columns_in_relation_raw macro that was introduced at #355 for adapters that inherits dbt-spark to override the macro.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-spark next" section.

@cla-bot cla-bot bot added the cla:yes label May 23, 2022
@ueshin ueshin mentioned this pull request May 23, 2022
Merged
4 tasks
@dbeatty10 dbeatty10 self-requested a review May 24, 2022 12:55
dbeatty10
dbeatty10 approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ueshin -- utilizing the dispatch pattern makes good sense. 👍

@dbeatty10 dbeatty10 merged commit 4c41d9e into dbt-labs:main May 31, 2022
@ueshin ueshin deleted the dispatch_get_columns_in_relation branch May 31, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbeatty10 dbeatty10 dbeatty10 approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ueshin @dbeatty10