Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor seed macros, clearer sql param logging #250

Merged
merged 2 commits into from
Nov 12, 2021

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Nov 8, 2021

resolves #249

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-spark next" section.

@cla-bot cla-bot bot added the cla:yes label Nov 8, 2021
@jtcohen6 jtcohen6 force-pushed the refactor/seed-materialization branch from 84c814f to 1f21b76 Compare November 8, 2021 12:36
@jtcohen6 jtcohen6 changed the title Refactor seed macros Refactor seed macros, clearer sql param logging Nov 8, 2021
@jtcohen6 jtcohen6 marked this pull request as ready for review November 8, 2021 13:29
@jtcohen6
Copy link
Contributor Author

jtcohen6 commented Nov 8, 2021

Integration test is failing because of a change we just merged into dbt-core: https:/dbt-labs/dbt-core/pull/4162/files#r744967964

@jtcohen6 jtcohen6 force-pushed the refactor/seed-materialization branch 2 times, most recently from 6e58f0c to 99e3dbc Compare November 10, 2021 12:42
@jtcohen6 jtcohen6 force-pushed the refactor/seed-materialization branch from 99e3dbc to 3b09190 Compare November 12, 2021 16:03
@jtcohen6 jtcohen6 force-pushed the refactor/seed-materialization branch from 3b09190 to 927a3e3 Compare November 12, 2021 16:08
@jtcohen6 jtcohen6 merged commit 05678b3 into main Nov 12, 2021
@jtcohen6 jtcohen6 deleted the refactor/seed-materialization branch November 12, 2021 16:42
vingov pushed a commit to vingov/dbt-spark that referenced this pull request Nov 17, 2021
* Try refactoring seed macros

* Add changelog entry
leahwicz added a commit that referenced this pull request Dec 3, 2021
* Refactor seed macros, clearer sql param logging (#250)

* Try refactoring seed macros

* Add changelog entry

* 187: Adding apache hudi support to dbt (#210)

* initial working version

* Rebased and resolve all the merge conflicts.

* Rebased and resolved merge conflicts.

* Removed hudi dep jar and used the released version via packages option

* Added insert overwrite unit tests for hudi

* Used unique_key as default value for hudi primaryKey option

* Updated changelog.md with this new update.

* Final round of testing and few minor fixes

* Fixed lint issues

* Fixed the integration tests

* Fixed the circle ci env to add hudi packages

* Updated hudi spark bundle to use scala 2.11

* Fixed Hudi incremental strategy integration tests and other integration tests

* Fixed the hudi hive sync hms integration test issues

* Added sql HMS config to fix the integration tests.

* Added hudi hive sync mode conf to CI

* Set the hms schema verification to false

* Removed the merge update columns hence its not supported.

* Passed the correct hiveconf to the circle ci build script

* Disabled few incremental tests for spark2 and reverted to spark2 config

* Added hudi configs to the circle ci build script

* Commented out the Hudi integration test until we have the hudi 0.10.0 version

* Fixed the macro which checks the table type.

* Disabled this model since hudi is not supported in databricks runtime, will be added later

* Update profile_template.yml for v1 (#247)

* Update profile_template.yml for v1

* PR feedback, fix indentation issues

* It was my intention to remove the square brackets

* Fixup changelog entry

* Merge main, update changelog

* Bump version to 1.0.0rc2 (#259)

* bumpversion 1.0.0rc2

* Update changelog

* Use pytest-dbt-adapter==0.6.0

* Corrected definition for set full_refresh_mode (#262)

* Replaced definition for set full_refresh_mode

* Updated changelog

* Edit changelog

Co-authored-by: Jeremy Cohen <[email protected]>

* `get_response` -> `AdapterResponse` (#265)

* Return AdapterResponse from get_response

* fix flake

Co-authored-by: Jeremy Cohen <[email protected]>
Co-authored-by: Vinoth Govindarajan <[email protected]>
Co-authored-by: Sindre Grindheim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it easier to debug sqlparam issues with seeds
2 participants