Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm py36 support, fix tests failing due to dbt-core changes #253

Merged
merged 3 commits into from
Nov 9, 2021

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Nov 8, 2021

No description provided.

@cla-bot cla-bot bot added the cla:yes label Nov 8, 2021
@jtcohen6 jtcohen6 requested a review from emmyoop November 8, 2021 23:53
@jtcohen6 jtcohen6 changed the title Fix tests failing due to dbt-core changes Rm py36 support, fix tests failing due to dbt-core changes Nov 9, 2021
@jtcohen6 jtcohen6 mentioned this pull request Nov 9, 2021
2 tasks
@jtcohen6
Copy link
Contributor Author

jtcohen6 commented Nov 9, 2021

I think we'll need to push a new version of our image, fishtownanalytics/test-container, that uses a newer version of python (ideally py38)

Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtcohen6
Copy link
Contributor Author

jtcohen6 commented Nov 9, 2021

@kwigley You're a genius. I clearly didn't read the tox file!

@jtcohen6 jtcohen6 merged commit 6e605cb into main Nov 9, 2021
@jtcohen6 jtcohen6 deleted the fix/failing-tests branch November 9, 2021 08:07
vingov pushed a commit to vingov/dbt-spark that referenced this pull request Nov 17, 2021
)

* Update tests/unit/utils.py per dbt-core#4212

* Rm py36 support, bump versions

* use python3.8 for testing

Co-authored-by: Kyle Wigley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants