Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_response -> AdapterResponse #265

Merged
merged 2 commits into from
Dec 3, 2021
Merged

get_response -> AdapterResponse #265

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c8abf8
Return AdapterResponse from get_response
jtcohen6 Dec 3, 2021
89d7283
fix flake
jtcohen6 Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions dbt/adapters/spark/connections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import dbt.exceptions
from dbt.adapters.base import Credentials
from dbt.adapters.sql import SQLConnectionManager
from dbt.contracts.connection import ConnectionState
from dbt.contracts.connection import ConnectionState, AdapterResponse
from dbt.events import AdapterLogger
from dbt.utils import DECIMALS
from dbt.adapters.spark import __version__
Expand Down Expand Up @@ -304,8 +304,12 @@ def cancel(self, connection):
connection.handle.cancel()

@classmethod
def get_response(cls, cursor):
return 'OK'
def get_response(cls, cursor) -> AdapterResponse:
# https:/dbt-labs/dbt-spark/issues/142
message = 'OK'
return AdapterResponse(
_message=message
)

# No transactions on Spark....
def add_begin_query(self, *args, **kwargs):
Expand Down