Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Calendar YML #230

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Conversation

callum-mcdata
Copy link
Contributor

What is this PR?

This is a:

  • bug fix with no breaking changes

Description & motivation

Fixes #229

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
    • Databricks

Tenets to keep in mind

  • A metric value should be consistent everywhere that it is referenced
  • We prefer generalized metrics with many dimensions over specific metrics with few dimensions
  • It should be easier to use dbt’s metrics than it is to avoid them
  • Organization and discoverability are as important as precision
  • One-off models built to power metrics are an anti-pattern

@cla-bot cla-bot bot added the cla:yes The CLA has been signed label Mar 31, 2023
@github-actions
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@callum-mcdata callum-mcdata merged commit 33656c5 into main Apr 3, 2023
@callum-mcdata callum-mcdata deleted the callum-mcdata/hotfix-calendar-yml branch April 3, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes The CLA has been signed
Projects
None yet
1 participant