Clarify freshness changes in source aren't whether the data is new #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size: x-small
✅ Deploy Preview for docs-getdbt-com canceled.
|
runleonarun
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
There's a lot of interest in detecting fresh data as a dbt selector. This is being worked on in dbt-labs/dbt-core#4050, but in the meantime users are confused by the current phrasing (example), which says that a source's
freshnessproperty changing would mark it as modified. What this actually means is when you change a source from being considered stale after 24 hours to 48 hours, not when new data has arrived in the source since the last dbt invocation.By adding another example and changing to a more active verb, I hope that this is clearer.