Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify tagging inheritance example #2580

Merged
merged 3 commits into from
Dec 16, 2022

Conversation

deanna-minnick
Copy link
Contributor

Description & motivation

This PR improves naming consistency and completes the logical flow in the source tag example at the bottom of tags.md. I confirmed that this logic works as expected in my own dbt project using the code below and running each permutation of dbt test -s tag:<tag_level> (ie dbt test -s tag:top_level).

version: 2

sources:
  - name: jaffle_shop
    tags: ['top_level']
    database: raw
    schema: jaffle_shop
    tables:
      - name: customers
        tags: ['table_level']
        columns:
          - name: id
            tags: ['column_level']
            tests:
              - unique:
                  tags: ['test_level']
      - name: orders```

@deanna-minnick deanna-minnick requested a review from a team as a code owner December 14, 2022 18:19
@github-actions github-actions bot added the content Improvements or additions to content label Dec 14, 2022
@netlify
Copy link

netlify bot commented Dec 14, 2022

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit cfdf5df
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/639c703ca7e7a80008d73f98
😎 Deploy Preview https://deploy-preview-2580--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the size: x-small This change will take under 3 hours to fix. label Dec 14, 2022
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding that clarification @deanna-minnick !

@deanna-minnick deanna-minnick merged commit a6b925b into current Dec 16, 2022
@deanna-minnick deanna-minnick deleted the feature/clarify-tagging-inheritance-example branch December 16, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants