Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about adapter_response in run_results.json, sources.json #495

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

jtcohen6
Copy link
Collaborator

Description & motivation

(reflects ongoing work in dbt-labs/dbt-core#2961 and future work proposed by dbt-labs/dbt-core#2964)

adapter_response is going to be the best place for users to grab out database-specific info like:

  • How many rows were created / inserted / updated / merged by this model run?
  • [BigQuery] How many bytes were processed?

Today, it is populated for all "true" materializations (model runs, seeds, snapshots), but it's left empty by dbt test and dbt source snapshot-freshness. We'd like to change that in a future release; the immediate benefit is for BigQuery users who want to know the bytes processed / $$ of tests and freshness checks.

Also, while today it only reflects the "last" query executed within a materialization, we'd love someday to record a response for each step in multi-step materializations (e.g. incremental models with create temp + delete + insert).

Pre-release docs

Is this change related to an unreleased version of dbt?

  • Yes: please
    • update the base branch to next
    • add Changelog components: <Changelog>[New/Changed] in v0.x.0</Changelog>
    • add links to the "New and changed documentation" section of the latest Migration Guide
  • No: please ensure the base branch is current
  • Unsure: we'll let you know!

Copy link
Contributor

@clrcrl clrcrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jtcohen6 jtcohen6 merged commit b7aead7 into next Jan 11, 2021
@jtcohen6 jtcohen6 deleted the update/adapter-response-dict branch January 11, 2021 10:45
nghi-ly pushed a commit that referenced this pull request May 2, 2024
REPO SYNC - Public to Private
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants