Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dbt-commands.md #5148

Merged
merged 4 commits into from
Mar 23, 2024
Merged

Update dbt-commands.md #5148

merged 4 commits into from
Mar 23, 2024

Conversation

ialdg
Copy link
Contributor

@ialdg ialdg commented Mar 23, 2024

Hi.
I addedd a "()" to the "X" option to be coherent, also the "(N/A)" at the same line, for clarity. The reader shouldn't be forced to look for it's meaning as a Table note. Lastly, I removed the last "command", since (as it's own explanation says) it's a flag, not a command. As a matter of fact, "--version" would be a good candidate for Table note. Regards.
IL.

What are you changing in this pull request and why?

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

Hi.
I addedd a "()" to the "X" option to be coherent, also the "(N/A)" at the same line, for clarity. The reader shouldn't be forced to look for it's meaning as a Table note.
Lastly, I removed the last "command", since (as it's own explanation says) it's a flag, not a command. As a matter of fact, "--version" would be a good candidate for Table note.
Regards.
IL.
@ialdg ialdg requested a review from a team as a code owner March 23, 2024 14:10
Copy link

vercel bot commented Mar 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 23, 2024 9:28pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Mar 23, 2024
@mirnawong1
Copy link
Contributor

mirnawong1 commented Mar 23, 2024

Hey @ialdg , this is a great point and really appreciate your input and pr! I agree with you and I'll review this on Monday and get this live. Happy to change the --version flag as a note as well.

Let us know if you have any other feedback - we're always wanting to improve the docs. looking forward to future contributions ✨!

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again @ialdg for opening this up and improving the docs. I've made some adjustments and the preview looks great!

Let me know if you have additional feedback!

@mirnawong1 mirnawong1 merged commit 038520a into dbt-labs:current Mar 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants