Add Mode queries #4
Conversation
mode_queries/parameters.sql
Outdated
| @@ -0,0 +1,18 @@ | |||
| select 1 | |||
|
|
|||
| {% form %} | |||
There was a problem hiding this comment.
can you put this form section into audience_overview.sql? we might want to add other queries in the future that could potentially have different parameters.
mode_queries/audience_overview.sql
Outdated
| sum(case when session_number = 1 then 1 else 0 end) as new_sessions, | ||
| sum(case when session_number > 1 then 1 else 0 end) as repeat_sessions | ||
|
|
||
| from dbt_claire.segment_web_sessions |
There was a problem hiding this comment.
you can use ref() in the analysis section as well!
mode_queries/audience_overview.sql
Outdated
| @@ -0,0 +1,15 @@ | |||
| select | |||
There was a problem hiding this comment.
this file should be located in analysis/ :) you probably haven't used that folder much! it's an oft-overlooked feature.
There was a problem hiding this comment.
I actually thought about that, but then figured because there was the form liquid tag, it would break. I'll just wrap the form tag in a raw tag 👍
mode_queries/audience_overview.sql
Outdated
| sum(case when session_number = 1 then 1 else 0 end) as new_sessions, | ||
| sum(case when session_number > 1 then 1 else 0 end) as repeat_sessions | ||
|
|
||
| from dbt_claire.segment_web_sessions |
There was a problem hiding this comment.
we still use the same SQL style guide for queries we write in mode. So--indentation, wrapping everything in CTEs, having an "import" CTE at the top (with sessions as...)
| @@ -0,0 +1,56 @@ | |||
| {#- | |||
There was a problem hiding this comment.
@drewbanin had a look at this with me, and he also couldn't get it to work.
dbt-labs/dbt-core#1152
There was a problem hiding this comment.
ok--maybe put this in a markdown file then? that way it won't attempt to be compiled.
There was a problem hiding this comment.
Going to keep it as the sql comment
|
@clrcrl hey! we should get this merged. I think these comments are all handled, right? |
No description provided.