Fix maintenance #18
Merged
Fix maintenance #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCZuurmond
force-pushed
the
fix-maintenance
branch
from
30e9a1d
to
68916bf
Compare
JCZuurmond
force-pushed
the
fix-maintenance
branch
from
ce0ac0c
to
7231741
Compare
|
@JCZuurmond Thanks for taking a swing at this (after #2 sitting dormant for a long time)! Is this ready for review/merge? |
JCZuurmond
force-pushed
the
fix-maintenance
branch
from
c2d94f8
to
29fd86c
Compare
|
it's ready to be merged yes! |
jtcohen6
approved these changes
Dec 17, 2021
There was a problem hiding this comment.
Tests are still failing, but those are unrelated to the addition of these macros. I'm down to ship these in a new minor version, and collect feedback as we go.
@JCZuurmond Thanks for the contribution, as always!
This was referenced Dec 17, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #2