Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial signals lost when no previous method call have been made #86

Closed
sdrik opened this issue Sep 18, 2021 · 0 comments · Fixed by #87
Closed

Initial signals lost when no previous method call have been made #86

sdrik opened this issue Sep 18, 2021 · 0 comments · Fixed by #87

Comments

@sdrik
Copy link
Contributor

sdrik commented Sep 18, 2021

ProxyInterface's listener is dropping signals if the sender does not match an already known name owner for the proxied object.

This can occur when no previous method call have been sent to this object, which is always the case for a newly XML-constructed proxy object. Moreover, if the object doesn't expose any method, it is simply impossible to get any signal from it !

In the introspection case, the initial org.freedesktop.Introspectable.Introspect call will always make the name owner initially known to the bus connection.
sdrik added a commit to sdrik/node-dbus-next that referenced this issue Sep 18, 2021
@sdrik
Add test for bug dbusjs#86
21656a3
sdrik added a commit to sdrik/node-dbus-next that referenced this issue Sep 18, 2021
@sdrik
Don't loose signals when no previous method calls have been made.
4ac6862 
ProxyInterface's listener is dropping signals if the sender does not
match an already known name owner for the proxied object.

This can occur when no previous method call have been sent to this
object, which is always the case for a newly XML-constructed proxy
object. Moreover, if the object doesn't expose any method, it is simply
impossible to get any signal from it !

In the introspection case, the initial
org.freedesktop.Introspectable.Introspect call will always make the name
owner initially known to the bus connection.

To prevent this, we're getting the name owner during the XML based
proxy construction by querying the org.freedesktop.DBus.GetNameOwner
method.

Fixes dbusjs#86
@sdrik sdrik mentioned this issue Sep 18, 2021
Merged
sdrik added a commit to sdrik/node-dbus-next that referenced this issue Sep 19, 2021
@sdrik
Fix comment in test for bug dbusjs#86
2320dc2
acrisci pushed a commit that referenced this issue Sep 19, 2021
Merge pull request #88 from sdrik/fix-comment-bug-86
4586780 
Fix comment in test for bug #86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't loose signals when no previous method calls have been made. sdrik/node-dbus-next
1 participant
@sdrik