Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable TCP support #26

Merged
merged 1 commit into from
May 8, 2019
Merged

Enable TCP support #26

merged 1 commit into from
May 8, 2019

Conversation

martenjacobs
Copy link
Contributor

Enabled TCP support, based on the way it's implemented in the upstream library. I split this out from #23.

@martenjacobs martenjacobs mentioned this pull request May 3, 2019
Closed
@martenjacobs
Copy link
Contributor Author

With regards to testing: I'm using socat to forward a TCP port to the system bus unix socket. Shouldn't we be able to set something like that up in the test suite (but using something else to connect the streams)?

@acrisci
Copy link
Member

acrisci commented May 8, 2019

Shouldn't we be able to set something like that up in the test suite

Yeah, another option might be to use a <listen> config in a custom dbus conf or an echo server or something. Whatever works the best. See dbus-daemon(1) for that option.

I think the CI issue isn't related to this so I'll merge and fix it later.

👍

@acrisci acrisci merged commit 35157b7 into dbusjs:master May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martenjacobs @acrisci