Error handling/messaging update

ddsjoberg · Oct 9, 2024 · b622a58 · b622a58
1 parent c1b7f26
commit b622a58
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/R/tbl_cross.R b/R/tbl_cross.R
@@ -73,7 +73,7 @@ tbl_cross <- function(data,
 
  # check inputs ---------------------------------------------------------------
  check_not_missing(data)
- if (!missing(row) + !missing(col) == 1L) {
+ if (sum(!missing(row), !missing(col)) == 1L) {
  cli::cli_abort(
  "Specify both {.arg row} and {.arg col} arguments or neither.",
  call = get_cli_abort_call()

diff --git a/tests/testthat/_snaps/tbl_cross.md b/tests/testthat/_snaps/tbl_cross.md
@@ -79,9 +79,7 @@
   tbl_cross(trial, col = trt)
  Condition
   Error in `tbl_cross()`:
-  ! Error processing `type` argument.
-  ! i In argument: `all_of(row)`. Caused by error in `all_of()`: ! Can't subset elements that don't exist. x Element `trt` doesn't exist.
-  i Select among columns "..total.."
+  ! Specify both `row` and `col` arguments or neither.
 
 ---