Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop 3.7 add 3.12 #142

Merged
merged 7 commits into from
Oct 11, 2023
Merged

drop 3.7 add 3.12 #142

merged 7 commits into from
Oct 11, 2023

Conversation

tonyfast
Copy link
Member

dropping 3.7 cause it is eol and adding the fresh 3.12.

@tonyfast
Copy link
Member Author

i showed up to work on this then bam... shits 🟢 . thanks for sorting all that out.

should i merge this? are there any things that needed to be followed up on?

@bollwyvl
Copy link
Contributor

In the hatch tooling refactor, I'm seeing we lost the test coverage under ipython -m... if you know an easy way to get that back, that'd be cool.

Ideally, we'd drop pytest-cov and run under coverage run -m pytest, with parallel = true, then coverage combine and coverage report them at the end to get a fully accurate picture, and establish a --fail-under.

Probably out of scope for this PR: we should look at upgrading (and using in CI) the linting mechanisms to include ruff and mypy... even if it's not possible to get passthrough types yet from imported notebooks, gotta start somewhere. We could also apply pyproject-fmt to pyproject.toml, though it has... a lot of opinions.

@tonyfast tonyfast changed the title WIP: drop 3.7 add 3.12 drop 3.7 add 3.12 Oct 11, 2023
@tonyfast
Copy link
Member Author

😎 i'll open some issues for these things.

with the typing, are you thinking notebook could be a source for types?

@tonyfast tonyfast merged commit b100659 into main Oct 11, 2023
18 checks passed
@bollwyvl
Copy link
Contributor

thinking notebook could be a source for types?

If it can be (was?) done for JSON Schema, I don't see why we couldn't get it for notebooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants