Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with VNU REST API #19

Merged
merged 15 commits into from
Dec 12, 2023
Merged

Test with VNU REST API #19

merged 15 commits into from
Dec 12, 2023

Conversation

bollwyvl
Copy link

@bollwyvl bollwyvl commented Dec 10, 2023

References

Elevator Pitch

This uses the vnu REST API to stand up a single HTTP server, and then requests to do POST requests.

At present, with only two tests that use this fixture, it's hard to assess whether it's worth the complexity, but at scale, it almost certainly would be.

Also, of note, the members of violations that come back don't have the url attribute. Presumably, this could be added back in.

Changes

  • normalize CI test setup
    • avoid some warnings with JUPYTER_PLATFORM_DIRS
    • use all conda-forge deps
    • enable rest of dev experience with .github/test-environment.yml
    • use a package.json and yarn.lock to get a reproducible version of axe-core
  • run linter
  • add fixtures for wrapping vnu server singleton
  • adds some env vars
    • NBA11Y_VNU_SERVER_URL (default: ``)
      • if not set, consult the following
        • NBA11Y_JAVA_PATH (default: ``, fallback: shutil.which('java'))
        • NBA11Y_VNU_JAR_PATH (default: ``, fallback: shutil.which('vnu'))
    • NBA11Y_CHROMIUM_CHANNEL (default: chrome-beta)
      • I don't let MS install rando stuff on my box as root, so have only tested with chromium

@bollwyvl bollwyvl changed the title [wip] Test with VNU REST API Dec 10, 2023
@bollwyvl bollwyvl changed the base branch from vnu-validator to main December 10, 2023 22:16
@bollwyvl bollwyvl marked this pull request as ready for review December 12, 2023 03:29
@tonyfast tonyfast merged commit 4edd547 into deathbeds:main Dec 12, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants