Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: replace high intensity foreground color for bold #182

Closed
dmarcelino opened this issue Mar 2, 2015 · 1 comment
Closed

node: replace high intensity foreground color for bold #182

dmarcelino opened this issue Mar 2, 2015 · 1 comment

Comments

@dmarcelino
Copy link
Contributor

Hi,

Debug is using high intensity foreground color for highlighting namespaces (\u001b[90m–\u001b[97m) which is not standard and results in no colors showing in some terminals (for example Titanium Studio's). I suggest we replace high intensity with bold, meaning, replacing node.js l.90:

    args[0] = '  \u001b[9' + c + 'm' + name + ' '

for:

    args[0] = '  \u001b[3' + c + ';1m' + name + ' '

Regards
dmarcelino added a commit to dmarcelino/debug that referenced this issue Mar 2, 2015
@dmarcelino
Issue debug-js#182: replace high intensity foreground color for bold
92eaeed
@dmarcelino dmarcelino mentioned this issue Mar 2, 2015
Merged
TooTallNate added a commit that referenced this issue Mar 13, 2015
@TooTallNate
Merge pull request #183 from dmarcelino/182-color_bold
1157441 
Issue #182: replace high intensity foreground color for bold
@dmarcelino
Copy link
Contributor Author

Thanks @TooTallNate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmarcelino