Added yarn integration to Makefile #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This essentially only affects development, though I'm not sure if we should be committing/publishing the yarn.lock file |
|
I asked the yarn team about this and they recommend keeping the lockfile in git. https://yarnpkg.com/en/docs/version-control#toc-required-files sez "The following files must be checked into source control for anyone to be able " |
|
Yeah I also heard that we should check in the lockfile @TooTallNate @paulirish |
|
BTW, sorry about the branch directly in the repo. Old habits (from work) die hard haha |
|
I guess it doesn't hurt. Feels kind of dirty committing a "generated" file like that. Same as |
I don't particularly mind. That's what git is for 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.