Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(browser): should check whether process exists #325

Closed
wants to merge 1 commit into from
Closed

fix(browser): should check whether process exists #325

wants to merge 1 commit into from

Conversation

tomtomau
Copy link
Contributor

Currently, 2.3.1 breaks in the browser. We need to check whether process is defined.

@stephenmathieson
Copy link
Contributor

stephenmathieson commented Nov 10, 2016 •
edited
Loading

Nice, I just did the same: https:/stephenmathieson/debug/commit/1213eb4f8a77248329526c6feac1f211938acf20

Ref: #324 (comment)

/cc @TooTallNate @thebigredgeek

@TooTallNate
Copy link
Contributor

Good catch. Let us know if v2.3.2 doesn't fix it for you guys.

@perrin4869
Copy link

Maybe a better idea is to do something like var process = require('process')?

@tomtomau tomtomau deleted the fix-browser branch November 10, 2016 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomtomau @stephenmathieson @TooTallNate @perrin4869