Disable colors in Edge and Internet Explorer #489
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #417
Both Internet Explorer and Edge report "AppleWebKit" in their
User-Agent
, so the currentuseColors()
function insrc/browser.js
returnstrue
(check my rationale about this here. But in fact, Edge and Internet Explorer do not support colors in the console.This PR checks whether the browser is Edge/IE and, if so, makes
useColors()
return false.NOTE: A good project for detecting browsers is bowser. In includes nice examples of how the
User-Agent
of many browsers looks like.