Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] add loadModel() to Critiera #1018

Merged
merged 1 commit into from
Jun 16, 2021
Merged

[api] add loadModel() to Critiera #1018

merged 1 commit into from
Jun 16, 2021

Conversation

frankfliu
Copy link
Contributor

Change-Id: Ie5c9f59ec283c780c323b2a99c440f416369c5fb

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

Change-Id: Ie5c9f59ec283c780c323b2a99c440f416369c5fb
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2021

Codecov Report

Merging #1018 (cbcb5d6) into master (50600fd) will decrease coverage by 0.03%.
The diff coverage is 83.60%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1018      +/-   ##
============================================
- Coverage     70.03%   70.00%   -0.04%     
- Complexity     5106     5123      +17     
============================================
  Files           504      504              
  Lines         22601    22677      +76     
  Branches       2367     2375       +8     
============================================
+ Hits          15828    15874      +46     
- Misses         5508     5537      +29     
- Partials       1265     1266       +1     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/ndarray/NDArray.java 73.25% <0.00%> (-0.43%) ⬇️
...c/main/java/ai/djl/pytorch/jni/PyTorchLibrary.java 100.00% <ø> (ø)
...src/main/java/ai/djl/pytorch/engine/PtNDArray.java 79.75% <50.00%> (-0.15%) ⬇️
.../src/main/java/ai/djl/repository/zoo/Criteria.java 88.33% <84.61%> (-1.52%) ⬇️
.../src/main/java/ai/djl/repository/zoo/ModelZoo.java 60.34% <100.00%> (-12.47%) ⬇️
...ine/src/main/java/ai/djl/pytorch/jni/JniUtils.java 90.64% <100.00%> (+0.07%) ⬆️
api/src/main/java/ai/djl/repository/Artifact.java 93.10% <0.00%> (+1.72%) ⬆️
...pi/src/main/java/ai/djl/ndarray/BaseNDManager.java 55.49% <0.00%> (+2.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec8405b...cbcb5d6. Read the comment docs.

Copy link
Contributor

@zachgk zachgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also move the listModels as well

@frankfliu frankfliu merged commit 2ce2857 into master Jun 16, 2021
@frankfliu frankfliu deleted the criteria branch June 16, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants