Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1024, Add back string tensor support #1040

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

frankfliu
Copy link
Contributor

Change-Id: I7b3f326669dec6739d24131d7507984390817226

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

Change-Id: I7b3f326669dec6739d24131d7507984390817226
@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2021

Codecov Report

Merging #1040 (ec45ecf) into master (6d951c9) will decrease coverage by 0.08%.
The diff coverage is 27.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1040      +/-   ##
============================================
- Coverage     70.09%   70.00%   -0.09%     
+ Complexity     5120     5119       -1     
============================================
  Files           504      504              
  Lines         22629    22654      +25     
  Branches       2375     2376       +1     
============================================
- Hits          15861    15859       -2     
- Misses         5498     5523      +25     
- Partials       1270     1272       +2     
Impacted Files Coverage Δ
.../main/java/ai/djl/tensorflow/engine/TfNDArray.java 85.23% <0.00%> (ø)
...ain/java/ai/djl/tensorflow/engine/TfNDManager.java 88.28% <0.00%> (-1.41%) ⬇️
...ai/djl/tensorflow/engine/javacpp/JavacppUtils.java 67.74% <29.72%> (-9.56%) ⬇️
api/src/main/java/ai/djl/repository/Artifact.java 91.37% <0.00%> (-1.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d951c9...ec45ecf. Read the comment docs.

@frankfliu frankfliu merged commit 79a6720 into deepjavalibrary:master Jun 22, 2021
@frankfliu frankfliu deleted the string branch June 22, 2021 19:56
Lokiiiiii pushed a commit to Lokiiiiii/djl that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants