Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Output endPosition induced by reaching EOS token #2730

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

KexinFeng
Copy link
Contributor

@KexinFeng KexinFeng commented Jul 31, 2023

This succeeds #2723

It enables getting endPositions, induced by reaching EOS token.

@KexinFeng KexinFeng requested review from zachgk, frankfliu and a team as code owners July 31, 2023 18:34
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 54.36% and project coverage change: +0.02% 🎉

Comparison is base (bb5073f) 72.08% compared to head (81bb8f1) 72.11%.
Report is 862 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2730      +/-   ##
============================================
+ Coverage     72.08%   72.11%   +0.02%     
- Complexity     5126     7044    +1918     
============================================
  Files           473      700     +227     
  Lines         21970    31346    +9376     
  Branches       2351     3238     +887     
============================================
+ Hits          15838    22606    +6768     
- Misses         4925     7197    +2272     
- Partials       1207     1543     +336     
Files Changed Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...djl/modality/cv/transform/RandomFlipLeftRight.java 25.00% <0.00%> (-25.00%) ⬇️
...djl/modality/cv/transform/RandomFlipTopBottom.java 25.00% <0.00%> (-25.00%) ⬇️
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <0.00%> (-5.24%) ⬇️
.../modality/cv/translator/ImageFeatureExtractor.java 0.00% <0.00%> (ø)
.../ai/djl/modality/cv/translator/YoloTranslator.java 27.77% <0.00%> (+18.95%) ⬆️
...ain/java/ai/djl/modality/cv/util/NDImageUtils.java 68.42% <0.00%> (+9.21%) ⬆️
api/src/main/java/ai/djl/modality/nlp/Decoder.java 63.63% <ø> (ø)
... and 226 more

... and 370 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KexinFeng KexinFeng merged commit ef5015c into deepjavalibrary:master Aug 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants