Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FFT2 and FFT2 inverse #2845

Merged
merged 11 commits into from
Nov 13, 2023
Merged

Add FFT2 and FFT2 inverse #2845

merged 11 commits into from
Nov 13, 2023

Conversation

TalGrbr
Copy link
Contributor

@TalGrbr TalGrbr commented Nov 9, 2023

Description

Brief description of what this PR is about

  • Added 2-dimensional FFT
  • Added 2-dimensional inverse FFT

@TalGrbr TalGrbr requested review from zachgk, frankfliu and a team as code owners November 9, 2023 16:19
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023

Codecov Report

Attention: 1365 lines in your changes are missing coverage. Please review.

Comparison is base (bb5073f) 72.08% compared to head (e662c66) 72.28%.
Report is 908 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2845      +/-   ##
============================================
+ Coverage     72.08%   72.28%   +0.19%     
- Complexity     5126     7160    +2034     
============================================
  Files           473      708     +235     
  Lines         21970    31908    +9938     
  Branches       2351     3313     +962     
============================================
+ Hits          15838    23066    +7228     
- Misses         4925     7263    +2338     
- Partials       1207     1579     +372     
Files Coverage Δ
...ava/ai/djl/inference/streaming/StreamingBlock.java 100.00% <100.00%> (ø)
api/src/main/java/ai/djl/metric/Dimension.java 100.00% <100.00%> (ø)
api/src/main/java/ai/djl/metric/Unit.java 100.00% <100.00%> (ø)
api/src/main/java/ai/djl/modality/audio/Audio.java 100.00% <100.00%> (ø)
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
...ava/ai/djl/modality/cv/output/DetectedObjects.java 96.29% <100.00%> (+1.29%) ⬆️
...rc/main/java/ai/djl/modality/cv/output/Joints.java 71.42% <100.00%> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...i/djl/modality/cv/transform/RandomResizedCrop.java 94.11% <100.00%> (+5.22%) ⬆️
... and 225 more

... and 385 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* @return The truncated or zero-padded input, transformed along the dimensions indicated by
* dims
*/
NDArray fft2(long[] sizes, long[] dims);
Copy link
Contributor

@zachgk zachgk Nov 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use axes instead of dims to be more consistent with the other operations in NDArray? Otherwise, your contribution looks good

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@zachgk zachgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zachgk zachgk merged commit f39640c into deepjavalibrary:master Nov 13, 2023
5 checks passed
frankfliu pushed a commit that referenced this pull request Apr 26, 2024
* Added 2D FFT

* Format java

* Add default fft2

* Convert array to vectors

* Add inverse fft2

* Add better assersion in ifft2 test

* Add really better assersion in ifft2 test

* Move cast bellow ifft2 for unsupported exception

* Format java

* changed dims to axes

* changed dims to axes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants