Suppress serial warning for JDK21 #2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In JDK21, it now throws the serial warning for including potentially unserializable instance variables. This includes the standard Java data structures like List, Set, and Map. This changes the JDK21 support from deepjavalibrary#2903 to suppress the warning rather than no longer serializing the variables.
frankfliu
reviewed
Jan 11, 2024
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2935 +/- ##
============================================
+ Coverage 72.08% 72.21% +0.12%
- Complexity 5126 7278 +2152
============================================
Files 473 721 +248
Lines 21970 32507 +10537
Branches 2351 3391 +1040
============================================
+ Hits 15838 23475 +7637
- Misses 4925 7413 +2488
- Partials 1207 1619 +412 ☔ View full report in Codecov by Sentry. |
frankfliu
approved these changes
Jan 15, 2024
frankfliu
pushed a commit
that referenced
this pull request
Apr 26, 2024
* Suppress serial warning for JDK21 In JDK21, it now throws the serial warning for including potentially unserializable instance variables. This includes the standard Java data structures like List, Set, and Map. This changes the JDK21 support from #2903 to suppress the warning rather than no longer serializing the variables. * Keep CategoryMask as transient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JDK21, it now throws the serial warning for including potentially unserializable instance variables. This includes the standard Java data structures like List, Set, and Map. This changes the JDK21 support from #2903 to suppress the warning rather than no longer serializing the variables.