Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] Support pre-downloaded rust shared library #3421

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

frankfliu
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu frankfliu requested review from zachgk and a team as code owners August 16, 2024 22:50
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 28.57143% with 25 lines in your changes missing coverage. Please review.

Project coverage is 58.31%. Comparing base (c4baffb) to head (63a32a4).
Report is 69 commits behind head on master.

Files with missing lines Patch % Lines
...va/ai/djl/huggingface/tokenizers/jni/LibUtils.java 28.57% 21 Missing and 4 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3421      +/-   ##
============================================
+ Coverage     58.25%   58.31%   +0.06%     
- Complexity     5737     5770      +33     
============================================
  Files           668      668              
  Lines         32509    32621     +112     
  Branches       3439     3468      +29     
============================================
+ Hits          18937    19022      +85     
- Misses        12125    12142      +17     
- Partials       1447     1457      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frankfliu frankfliu merged commit 2d3669b into deepjavalibrary:master Aug 17, 2024
5 checks passed
@frankfliu frankfliu deleted the hf branch August 17, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants