Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[djl-convert] Sets default max model size limit for importing #3428

Merged
merged 1 commit into from
Aug 19, 2024
Merged

[djl-convert] Sets default max model size limit for importing #3428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions extensions/tokenizers/src/main/python/djl_converter/huggingface_converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ def __init__(self):
self.translator = None
self.inputs = None
self.outputs = None
self.max_model_size = int(os.getenv("MAX_MODEL_SIZE", "2_000_000_000"))
self.api = HfApi()

def save_model(self, model_info, task: str, args: Namespace, temp_dir: str,
Expand Down Expand Up @@ -103,6 +104,9 @@ def save_onnx_model(self, model_info, task: str, args: Namespace,
temp_dir, hf_pipeline,
include_types)
if model_zoo:
model_size = self.get_dir_size(temp_dir)
if model_size > self.max_model_size:
return False, f"Model size too large: {model_size}", -1
size = self.save_to_model_zoo(model_info, args.output_dir,
"OnnxRuntime", temp_dir, arguments)
else:
Expand Down Expand Up @@ -183,6 +187,9 @@ def save_rust_model(self, model_info, args: Namespace, temp_dir: str,
arguments = self.save_serving_properties(model_info, "Rust", temp_dir,
hf_pipeline, include_types)
if model_zoo:
model_size = self.get_dir_size(temp_dir)
if model_size > self.max_model_size:
return False, f"Model size too large: {model_size}", -1
size = self.save_to_model_zoo(model_info, args.output_dir, "Rust",
temp_dir, arguments)
else:
Expand Down Expand Up @@ -231,6 +238,9 @@ def save_pytorch_model(self, model_info, args: Namespace, temp_dir: str,
temp_dir, hf_pipeline,
include_types)
if model_zoo:
model_size = self.get_dir_size(temp_dir)
if model_size > self.max_model_size:
return False, f"Model size too large: {model_size}", -1
size = self.save_to_model_zoo(model_info, args.output_dir,
"PyTorch", temp_dir, arguments)
else:
Expand Down Expand Up @@ -332,6 +342,17 @@ def save_to_model_zoo(self, model_info, output_dir: str, engine: str,

return file_size

@staticmethod
def get_dir_size(path: str) -> int:
total = 0
with os.scandir(path) as it:
for entry in it:
if entry.is_file():
total += entry.stat().st_size
elif entry.is_dir():
total += HuggingfaceConverter.get_dir_size(entry.path)
return total

def verify_jit_model(self, hf_pipeline, model_file: str,
include_types: bool, cpu_only: bool):
logging.info(
Expand Down
3 changes: 2 additions & 1 deletion extensions/tokenizers/src/main/python/djl_converter/sentence_similarity_converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,5 +163,6 @@ def get_extra_arguments(self, hf_pipeline, model_id: str,
@staticmethod
def save_module_weight(model_id: str, temp_dir: str, layer: str,
name: str):
file = self.get_file(model_id, f"{layer}/model.safetensors")
file = SentenceSimilarityConverter.get_file(
model_id, f"{layer}/model.safetensors")
shutil.copyfile(file, os.path.join(temp_dir, f"{name}.safetensors"))
Loading