Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use custom NDK version instead of action default NDK #531

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Use custom NDK version instead of action default NDK #531

merged 1 commit into from
Jan 15, 2021

Conversation

stu1130
Copy link
Contributor

@stu1130 stu1130 commented Jan 15, 2021

PyTorch Android native build only works on NDK version 20.
Action uses version 22 by default.

@lanking520
Copy link
Contributor

Have you tested the android pipeline?

@stu1130
Copy link
Contributor Author

stu1130 commented Jan 15, 2021 •
edited
Loading

Have you tested the android pipeline?

I tested it on my local repo https:/stu1130/djl/runs/1705801591?check_suite_focus=true you can see it only failed on upload part

@stu1130 stu1130 merged commit 9367233 into deepjavalibrary:master Jan 15, 2021
@stu1130 stu1130 deleted the fix_android branch January 15, 2021 02:27
Lokiiiiii pushed a commit to Lokiiiiii/djl that referenced this pull request Oct 10, 2023
@frankfliu
[inf2] Fixes NeuronUtils.getNeuronCores() bug (deepjavalibrary#531)
8a90769
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanking520 lanking520 lanking520 approved these changes

@frankfliu frankfliu Awaiting requested review from frankfliu

@roywei roywei Awaiting requested review from roywei

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stu1130 @lanking520