List input and output classes in ModelZoo lookup #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will list the input and output classes when trying to find a model in the model zoo. It works either when no classes are specified or invalid classes are specified. This will help users who don't know what the possible classes are to resolve the question without looking at the code. Change-Id: Ideecb0c0b56699a7023d50f2cf3da54010197112
stu1130
approved these changes
Feb 8, 2021
frankfliu
reviewed
Feb 9, 2021
| @@ -199,12 +200,24 @@ public String toString() { | |||
| @SuppressWarnings("unchecked") | |||
| private <I, O> TranslatorFactory<I, O> getTranslatorFactory(Criteria<I, O> criteria) { | |||
| if (criteria.getInputClass() == null) { | |||
| throw new IllegalArgumentException("The criteria must set an input class"); | |||
| throw new IllegalArgumentException( | |||
There was a problem hiding this comment.
Suggested change
| throw new IllegalArgumentException( | |
| throw new IllegalArgumentException(getErrorMessage("The criteria must set an input class.\n"); |
| @@ -199,12 +200,24 @@ public String toString() { | |||
| @SuppressWarnings("unchecked") | |||
| private <I, O> TranslatorFactory<I, O> getTranslatorFactory(Criteria<I, O> criteria) { | |||
| if (criteria.getInputClass() == null) { | |||
| throw new IllegalArgumentException("The criteria must set an input class"); | |||
| throw new IllegalArgumentException( | |||
| "The criteria must set an input class.\n" + printTranslatorFactories()); | |||
There was a problem hiding this comment.
Suggested change
| "The criteria must set an input class.\n" + printTranslatorFactories()); |
Change-Id: I95719122be62952a6b9793571d345656eb7a99bd
frankfliu
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will list the input and output classes when trying to find a model in the
model zoo. It works either when no classes are specified or invalid classes are
specified. This will help users who don't know what the possible classes are to
resolve the question without looking at the code.