Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Fix saveModel NPE bug #989

Merged
merged 1 commit into from
May 30, 2021
Merged

Conversation

frankfliu
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

Change-Id: I288d6ca80a7e987f2e527e18f020fee0f75d8156
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2021

Codecov Report

Merging #989 (60b6289) into master (62c0770) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #989   +/-   ##
=========================================
  Coverage     70.02%   70.02%           
- Complexity     5085     5086    +1     
=========================================
  Files           502      502           
  Lines         22519    22521    +2     
  Branches       2359     2360    +1     
=========================================
+ Hits          15768    15770    +2     
  Misses         5495     5495           
  Partials       1256     1256           
Impacted Files Coverage Δ
api/src/main/java/ai/djl/BaseModel.java 73.64% <0.00%> (-1.01%) ⬇️
...c/main/java/ai/djl/mxnet/engine/MxSymbolBlock.java 83.45% <0.00%> (+1.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62c0770...60b6289. Read the comment docs.

@frankfliu frankfliu merged commit 6dc2949 into deepjavalibrary:master May 30, 2021
@frankfliu frankfliu deleted the saveModel branch May 30, 2021 17:38
Lokiiiiii pushed a commit to Lokiiiiii/djl that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants