chore: remove retry-action action on registry1 docker login #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orking-and-broke-on-latest-update
mjnagel
approved these changes
Feb 8, 2024
zachariahmiller
deleted the
158-remove-retry-action-that-isnt-actually-working-and-broke-on-latest-update
branch
jeff-mccoy
pushed a commit
that referenced
this pull request
Feb 9, 2024
🤖 I have created a release *beep* *boop* --- ## [0.12.0](v0.11.1...v0.12.0) (2024-02-09) ### Features * introduce advancedHTTP for expose field & change podLabels to selector ([#154](#154)) ([1079267](1079267)) ### Miscellaneous * **deps:** pin dependencies ([#79](#79)) ([bfab11e](bfab11e)) * remove retry-action action on registry1 docker login ([#160](#160)) ([eea0c93](eea0c93)) --- This PR was generated with [Release Please](https:/googleapis/release-please). See [documentation](https:/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
robmcelvenny
pushed a commit
to owen-grady/uds-core-slim-dev
that referenced
this pull request
Jun 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.12.0](defenseunicorns/uds-core@v0.11.1...v0.12.0) (2024-02-09) ### Features * introduce advancedHTTP for expose field & change podLabels to selector ([#154](defenseunicorns/uds-core#154)) ([1079267](defenseunicorns/uds-core@1079267)) ### Miscellaneous * **deps:** pin dependencies ([#79](defenseunicorns/uds-core#79)) ([bfab11e](defenseunicorns/uds-core@bfab11e)) * remove retry-action action on registry1 docker login ([#160](defenseunicorns/uds-core#160)) ([eea0c93](defenseunicorns/uds-core@eea0c93)) --- This PR was generated with [Release Please](https:/googleapis/release-please). See [documentation](https:/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
revert using retry action on the docker login action for logging into registry1. A separate, followup issue will address this differently in the future. This is just reverting the change that added the reliance on the 3rd party action that wasnt serving its purpose and had a lacking update cadence.
Type of change
Checklist before merging