Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --version flag to the CLI args #60

Closed
devigned opened this issue Dec 21, 2022 · 5 comments
Closed

add --version flag to the CLI args #60

devigned opened this issue Dec 21, 2022 · 5 comments

Comments

@devigned
Copy link
Member

It would be nice to have a --version arg for the shims to be able to determine the build version information. Currently, there is no way to easily determine the version of the shim bin.

@devigned devigned changed the title add --version flag to the CLI args add --version flag to the CLI args Dec 21, 2022
@devigned devigned changed the title add --version flag to the CLI args add --version flag to the CLI args Dec 21, 2022
@Mossaka
Copy link
Member

Mossaka commented Feb 15, 2023

Can you elaborate more on where the --version argument is passed to?

This is the current behaviour:
image

Do you envision instead of the above, it will prints out the version info?

@devigned
Copy link
Member Author

Yes. It doesn't need to be --version, but in some way to be able to determine what version is running. In cases where we need to debug an issue, it would be super helpful for someone to easily determine the version / build of a shim on their system and then open an issue with that info.

@Mossaka
Copy link
Member

Mossaka commented Feb 16, 2023

I think containerd-shim is probably a better place to add the version flag. Here is an issue I created containerd/rust-extensions#120

@Mossaka
Copy link
Member

Mossaka commented Aug 18, 2023

We should follow what's done in containerd/rust-extensions#167 to bring the version flag to all the shims.

@Mossaka
Copy link
Member

Mossaka commented Sep 19, 2023

Close by #145

@Mossaka Mossaka closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants